ShellDetect falls back to filetype if no hashbang (fixes #2886)#2906
Merged
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Aug 17, 2020
elebow:shelldetect-fall-back-to-filetype-if-no-hashbangelebow/ale:shelldetect-fall-back-to-filetype-if-no-hashbangCopy head branch name to clipboard
Merged
ShellDetect falls back to filetype if no hashbang (fixes #2886)#2906w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom elebow:shelldetect-fall-back-to-filetype-if-no-hashbangelebow/ale:shelldetect-fall-back-to-filetype-if-no-hashbangCopy head branch name to clipboard
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
elebow:shelldetect-fall-back-to-filetype-if-no-hashbangelebow/ale:shelldetect-fall-back-to-filetype-if-no-hashbangCopy head branch name to clipboard
Conversation
Some files lack a hashbang line but still have an unambiguous filetype. For example, the file `.zshrc` has the filetype `zsh`. Augment ale#handlers#sh#GetShellType to fall back to the filetype if no hashbang line can be found.
The shell linter does more than just bash.
445c6e6 to
ece229c
Compare
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Member
Author
|
@w0rp, I believe this is still ready for review. |
w0rp
approved these changes
Aug 17, 2020
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some files lack a hashbang line but still have an unambiguous filetype. For example, the file
.zshrchas the filetypezsh.Augment
ale#handlers#sh#GetShellTypeto fall back to the filetype if no hashbang line can be found.Also update the description of the
shelllinter, which does more than just bash now.Fixes #2886.