add project_root_callback for tsserver#2290
Merged
w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom Feb 11, 2019
dsifford:dsifford-tsserver-project-rootCopy head branch name to clipboard
Merged
add project_root_callback for tsserver#2290w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom dsifford:dsifford-tsserver-project-rootCopy head branch name to clipboard
w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom
dsifford:dsifford-tsserver-project-rootCopy head branch name to clipboard
Conversation
w0rp
requested changes
Feb 11, 2019
Member
w0rp
left a comment
There was a problem hiding this comment.
Makes sense. The root is never sent to tsserver, but the string can be used for running separate instances. Add a test for this. Look at tests that use AssertLSPProject.
Contributor
Author
|
@w0rp Look those over when you get time and let me know if I did that correctly. Thanks |
w0rp
approved these changes
Feb 11, 2019
w0rp
requested changes
Feb 11, 2019
…k.vader Co-Authored-By: dsifford <dereksifford@gmail.com>
w0rp
approved these changes
Feb 11, 2019
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds in a
project_root_callbackfor tsserver to make tsserver work as intended in projects that have nestedtsconfig.jsonfiles.I tested these changes in a repo I was having issues with and these changes resolved my problem.
Let me know if you need anything further.