Support ale_sh_shellcheck_dialect to set shellcheck dialect#2289
Merged
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom Feb 10, 2019
Merged
Support ale_sh_shellcheck_dialect to set shellcheck dialect#2289w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
Conversation
As discussed in dense-analysis#1051, there are cases where it would be useful to be able to specify the dialect explicitly. This commit allows users to do so using the ale_sh_shellcheck_dialect variable. Fixes: dense-analysis#1051 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
w0rp
approved these changes
Feb 10, 2019
Member
|
Yep, you can sometimes figure out something better than a machine can. |
Member
|
Cheers! 🍻 |
Contributor
Author
|
Yes indeed. Thanks @w0rp! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1051, there are cases (including my own) where it would be useful to be able to specify the dialect explicitly or allow
shellcheckto determine the dialect using its own logic and considering# shellcheck shell=directives in the file. This commit allows users to do so using theale_sh_shellcheck_dialectvariable, which can be set empty to disable auto-detection or set to a particular dialect to use it unconditionally.Fixes: #1051
Thanks for considering,
Kevin