Center the result after ale#util#Open jumps#2277
Merged
w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom Feb 10, 2019
chaucerbao:feature/redraw-after-openCopy head branch name to clipboard
Merged
Center the result after ale#util#Open jumps#2277w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom chaucerbao:feature/redraw-after-openCopy head branch name to clipboard
ale#util#Open jumps#2277w0rp merged 4 commits intodense-analysis:masterdense-analysis/ale:masterfrom
chaucerbao:feature/redraw-after-openCopy head branch name to clipboard
Conversation
Contributor
Author
|
Also, let me know what you think about centering the line within the viewport with: normal zzafter the call cursor(). |
Contributor
Author
|
I just added it in anyway. If you don't like that behavior, I can easily remove it. |
Contributor
Author
|
Okay, well since the |
redraw after ale#util#Openale#util#Open jumps
ale#util#Open jumpsale#util#Open jumps
w0rp
approved these changes
Feb 10, 2019
Member
w0rp
left a comment
There was a problem hiding this comment.
I thought about this a bit. I say let's go with it. If someone doesn't like it, we can add a setting to disable it.
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases, when I use
:ALEGoToDefinition(or other jumping call) and it leads to a location in the same file, the cursor moves, but the screen does not redraw. Then, when I use a motion movement or wait a few seconds, the screen will finally update. This may be due to Vim'slazyredrawsetting.This PR forces a redraw after the cursor moves.