Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add settings for the Alex linter#2268

Merged
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
m-pilia:alexCopy head branch name to clipboard
Feb 10, 2019
Merged

Add settings for the Alex linter#2268
w0rp merged 1 commit intodense-analysis:masterdense-analysis/ale:masterfrom
m-pilia:alexCopy head branch name to clipboard

Conversation

@m-pilia
Copy link
Copy Markdown
Contributor

@m-pilia m-pilia commented Feb 2, 2019

The executable for the Alex linter is currently hard-coded as 'alex',
which is an issue given the fact that it conflicts with the Haskell
lexer generator, whose executable is also called 'alex', has been around
a dozen years before the linter, and is packaged in the official
repositories of the major Linux distributions.

This commit adds options to use a local executable for the alex linter
(which is a node package), and an option to set a custom executable.

As side changes:

  • The pattern in the alex handler is made more readable by turnig it
    into a very-magic regex.
  • Alex handles plain text, markdown, and HTML. Specific flags for HTML
    and markdown are provided when instantiating the linters for the
    respective filetypes, while before those formats were treated as plain
    text.

Resolves #1633

The executable for the Alex linter is currently hard-coded as 'alex',
which is an issue given the fact that it conflicts with the Haskell
lexer generator, whose executable is also called 'alex', has been around
a dozen years before the linter, and is packaged in the official
repositories of the major Linux distributions.

This commit adds options to use a local executable for the alex linter
(which is a node package), and an option to set a custom executable.

As side changes:
* The pattern in the alex handler is made more readable by turnig it
  into a very-magic regex.
* Alex handles plain text, markdown, and HTML. Specific flags for HTML
  and markdown are provided when instantiating the linters for the
  respective filetypes, while before those formats were treated as plain
  text.
@w0rp w0rp merged commit 6ebe24b into dense-analysis:master Feb 10, 2019
@w0rp
Copy link
Copy Markdown
Member

w0rp commented Feb 10, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.