Fix cflags parsing#2194
Merged
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom Jan 10, 2019
fx-carton:fix-cflags-parsingCopy head branch name to clipboard
Merged
Fix cflags parsing#2194w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom fx-carton:fix-cflags-parsingCopy head branch name to clipboard
w0rp merged 2 commits intodense-analysis:masterdense-analysis/ale:masterfrom
fx-carton:fix-cflags-parsingCopy head branch name to clipboard
Conversation
|
My manual test is probably covering the same code as the automatic test, but I can confirm this is working for me. Thanks for fixing this up! |
w0rp
approved these changes
Jan 10, 2019
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug mentionned in #2168. A relevant test case has been added.