Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add snapshot and full_snapshot_file_path to BreakpointException #9828

Copy link
Copy link
@sjrl

Description

@sjrl
Issue body actions

Is your feature request related to a problem? Please describe.
While working on Human-in-the-Loop interruption and confirmation with our Pipeline Breakpoint feature in deepset-ai/haystack-experimental#369, I encountered some pain points.

It would be convenient if BreakpointException returned the snapshot as an attribute, similar to the recent addition in PipelineRuntimeError. Additionally, having the full file path including the file name of the saved snapshot would help, as we currently auto-generate the file name and it's not easy to determine from just the directory path.

Describe the solution you'd like
Add snapshot and full_snapshot_file_path attributes to BreakpointException to make it easier for users to locate and work with the snapshot.

Additional context
I suggest full_snapshot_file_path since snapshot_file_path in Breakpoint currently only contains the directory path. The full_ prefix clarifies that this includes both the directory path and the file name.

Metadata

Metadata

Assignees

Labels

P1High priority, add to the next sprintHigh priority, add to the next sprint

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.