This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Branch providing a safe implementation#1
Open
victorporof wants to merge 2 commits intodcodeIO:masterdcodeIO/colour.js:masterfrom
victorporof:safeCopy head branch name to clipboard
Open
Branch providing a safe implementation#1victorporof wants to merge 2 commits intodcodeIO:masterdcodeIO/colour.js:masterfrom victorporof:safeCopy head branch name to clipboard
victorporof wants to merge 2 commits intodcodeIO:masterdcodeIO/colour.js:masterfrom
victorporof:safeCopy head branch name to clipboard
Conversation
Signed-off-by: Victor Porof <victor.porof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest having a branch in this project with a safe implementation that never touches the String prototype.
I've looked into augmenting the default implementation on master with an option to avoid touching the String prototype on import, but afaict that cannot be easily done at the moment without significant code duplication, but as it stands it seems that this library is intended to also be used as a drop-in in browser environments without a webpack, browserify or even some sort of concatenation build step.