fix: 【发行为混合分包】TypeError: t.$callHook is not a function #4829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition that resulted in a TypeError when using mixed subpackages in uniapp by synchronously assigning hook functions to the application context.
- Synchronously assigns $hasHook and $callHook to resolve the asynchronous initialization issue.
- Ensures hooks are available before onLaunch completes.
| allowDefault: true, | ||
| }) | ||
| if (!app) return | ||
| ;(vm.$ as any).ctx.$scope = app |
There was a problem hiding this comment.
Assigning '$hasHook' and '$callHook' synchronously resolves the async race condition that previously resulted in 't.$callHook is not a function'. Consider adding a comment explaining why these assignments are done here for future maintainability.
Suggested change
| ;(vm.$ as any).ctx.$scope = app | |
| ;(vm.$ as any).ctx.$scope = app | |
| // Assigning `$hasHook` and `$callHook` synchronously is critical to prevent | |
| // an async race condition that could result in `t.$callHook is not a function`. | |
| // Do not modify the order or timing of these assignments without understanding | |
| // the potential impact on app lifecycle hooks. |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
|
我试了一下这个确实能解决问题，但是为什么官方不合并 |
|
这个修复也不对吧， |
1. 当发行为混合分包的时候，uniapp 会调用 initCreateSubpackageApp 方法
2. initCreateSubpackageApp 里调用 parseApp ，并在 onLaunch 时候进行 initBaseInstance
3. initCreateSubpackageApp 里调用 parseApp 后同步执行 `vm.$.ctx.$scope = app;`
4. initBaseInstance 在 onLaunch 会进行 `if (this.$vm && ctx.$scope) {return;}` 阻断，如果通过则执行 `ctx.$hasHook = hasHook; ctx.$callHook = callHook;`
问题出在 onLaunch 是异步的，导致 4 的流程阻断，没有执行 $callHook 赋值，最终导致 `initAppLifecycle` 中的 `vm.$callHook` 为 undefined
518d7cb to
3b42482
Compare
|
@viccici 我调整了代码，你再看下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4781
close #4422
当发行为混合分包的时候，uniapp 会调用 initCreateSubpackageApp 方法
initCreateSubpackageApp 里调用 parseApp ，并在 onLaunch 时候进行 initBaseInstance
initCreateSubpackageApp 里调用 parseApp 后同步执行
vm.$.ctx.$scope = app;initBaseInstance 在 onLaunch 会进行
if (this.$vm && ctx.$scope) {return;}阻断，如果通过则执行ctx.$hasHook = hasHook; ctx.$callHook = callHook;问题出在 onLaunch 是异步的，导致 4 的流程阻断，没有执行 $callHook 赋值，最终导致
initAppLifecycle中的vm.$callHook为 undefined