This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Add missing support for <s> tags for striketrough#26
Open
creynaud wants to merge 2 commits intodbowen:masterdbowen/NSAttributedString-DDHTML:masterfrom
Open
Add missing support for <s> tags for striketrough#26creynaud wants to merge 2 commits intodbowen:masterdbowen/NSAttributedString-DDHTML:masterfrom
creynaud wants to merge 2 commits intodbowen:masterdbowen/NSAttributedString-DDHTML:masterfrom
Conversation
<s> is also a tag that should be interpreted as strikethrough. With strncmp, when a "s" tag is compared with "strong", it returns 0 because only 1 character is compared -> use strcmp instead.
Author
|
Hi, Do you have any feedbacks on this pull request? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is split into 2 commits: