Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5b92d4b

Browse filesBrowse files
committed
Fix findbugs false alarms
1 parent 4daf6ba commit 5b92d4b
Copy full SHA for 5b92d4b

File tree

Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed

‎src/main/java/org/kohsuke/github/GHCommitComment.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/GHCommitComment.java
-10Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,6 @@ public class GHCommitComment extends GHObject {
2323
String path;
2424
GHUser user; // not fully populated. beware.
2525

26-
static class User {
27-
// TODO: what if someone who doesn't have an account on GitHub makes a commit?
28-
@SuppressFBWarnings(value = "UUF_UNUSED_FIELD", justification = "We don't provide it in API now")
29-
String url,avatar_url,gravatar_id;
30-
@SuppressFBWarnings(value = "UUF_UNUSED_FIELD", justification = "We don't provide it in API now")
31-
int id;
32-
33-
String login;
34-
}
35-
3626
public GHRepository getOwner() {
3727
return owner;
3828
}

‎src/main/java/org/kohsuke/github/GHEventPayload.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/GHEventPayload.java
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,8 @@ void wrapUp(GitHub root) {
428428
*
429429
* @see <a href="http://developer.github.com/v3/activity/events/types/#pushevent">authoritative source</a>
430430
*/
431+
@SuppressFBWarnings(value = {"UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
432+
justification = "Constructed by JSON deserialization")
431433
public static class Push extends GHEventPayload {
432434
private String head, before;
433435
private boolean created, deleted, forced;
@@ -553,6 +555,8 @@ public List<String> getModified() {
553555
*
554556
* @see <a href="http://developer.github.com/v3/activity/events/types/#repositoryevent">authoritative source</a>
555557
*/
558+
@SuppressFBWarnings(value = {"UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR", "NP_UNWRITTEN_FIELD", "UWF_UNWRITTEN_FIELD"},
559+
justification = "Constructed by JSON deserialization")
556560
public static class Repository extends GHEventPayload {
557561
private String action;
558562
private GHRepository repository;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.