Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 63041bc

Browse filesBrowse files
committed
rm all traces of appendVersion:
- appending `Plotly.version` is the bundle break UMD more info: plotly#14
1 parent 734f75f commit 63041bc
Copy full SHA for 63041bc

File tree

4 files changed

+6
-56
lines changed
Filter options

4 files changed

+6
-56
lines changed

‎tasks/bundle.js

Copy file name to clipboardExpand all lines: tasks/bundle.js
+4-19Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ var browserify = require('browserify');
44
var UglifyJS = require('uglify-js');
55

66
var compressAttributes = require('./util/compress_attributes');
7-
var appendVersion = require('./util/append_version');
87
var constants = require('./util/constants');
98

109
/*
@@ -48,19 +47,11 @@ browserify(constants.pathToPlotlySrc, {
4847
if(!DEV) {
4948
fs.writeFile(
5049
constants.pathToPlotlyDistMin,
51-
UglifyJS.minify(buf.toString(), constants.uglifyOptions).code,
52-
function() {
53-
appendVersion(
54-
constants.pathToPlotlyDistMin, {object: 'Plotly'}
55-
);
56-
}
50+
UglifyJS.minify(buf.toString(), constants.uglifyOptions).code
5751
);
5852
}
5953
})
60-
.pipe(fs.createWriteStream(constants.pathToPlotlyDist))
61-
.on('finish', function() {
62-
appendVersion(constants.pathToPlotlyDist, {object: 'Plotly', DEV: DEV});
63-
});
54+
.pipe(fs.createWriteStream(constants.pathToPlotlyDist));
6455

6556

6657
// Browserify the geo assets
@@ -70,10 +61,7 @@ browserify(constants.pathToPlotlyGeoAssetsSrc, {
7061
.bundle(function(err) {
7162
if(err) throw err;
7263
})
73-
.pipe(fs.createWriteStream(constants.pathToPlotlyGeoAssetsDist))
74-
.on('finish', function() {
75-
appendVersion(constants.pathToPlotlyGeoAssetsDist, {object: 'PlotlyGeoAssets'});
76-
});
64+
.pipe(fs.createWriteStream(constants.pathToPlotlyGeoAssetsDist));
7765

7866

7967
// Browserify the plotly.js with meta
@@ -84,7 +72,4 @@ browserify(constants.pathToPlotlySrc, {
8472
.bundle(function(err) {
8573
if(err) throw err;
8674
})
87-
.pipe(fs.createWriteStream(constants.pathToPlotlyDistWithMeta))
88-
.on('finish', function() {
89-
appendVersion(constants.pathToPlotlyDistWithMeta, {object: 'Plotly', DEV: DEV});
90-
});
75+
.pipe(fs.createWriteStream(constants.pathToPlotlyDistWithMeta));

‎tasks/cibundle.js

Copy file name to clipboardExpand all lines: tasks/cibundle.js
+2-9Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ var fs = require('fs');
33
var browserify = require('browserify');
44

55
var compressAttributes = require('./util/compress_attributes');
6-
var appendVersion = require('./util/append_version');
76
var constants = require('./util/constants');
87

98
/*
@@ -24,10 +23,7 @@ browserify(constants.pathToPlotlySrc, {
2423
.bundle(function(err) {
2524
if(err) throw err;
2625
})
27-
.pipe(fs.createWriteStream(constants.pathToPlotlyBuild))
28-
.on('finish', function() {
29-
appendVersion(constants.pathToPlotlyBuild, {object: 'Plotly'});
30-
});
26+
.pipe(fs.createWriteStream(constants.pathToPlotlyBuild));
3127

3228

3329
// Browserify the geo assets
@@ -37,7 +33,4 @@ browserify(constants.pathToPlotlyGeoAssetsSrc, {
3733
.bundle(function(err) {
3834
if(err) throw err;
3935
})
40-
.pipe(fs.createWriteStream(constants.pathToPlotlyGeoAssetsDist))
41-
.on('finish', function() {
42-
appendVersion(constants.pathToPlotlyGeoAssetsDist, {object: 'PlotlyGeoAssets'});
43-
});
36+
.pipe(fs.createWriteStream(constants.pathToPlotlyGeoAssetsDist));

‎tasks/util/append_version.js

Copy file name to clipboardExpand all lines: tasks/util/append_version.js
-24Lines changed: 0 additions & 24 deletions
This file was deleted.

‎tasks/util/make_watchified_bundle.js

Copy file name to clipboardExpand all lines: tasks/util/make_watchified_bundle.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ var browserify = require('browserify');
44
var watchify = require('watchify');
55

66
var compressAttributes = require('./compress_attributes');
7-
var appendVersion = require('./append_version');
87
var formatBundleMsg = require('./format_bundle_msg');
98
var constants = require('./constants');
109

@@ -53,9 +52,6 @@ module.exports = function makeWatchifiedBundle(onFirstBundleCallback) {
5352
.pipe(
5453
fs.createWriteStream(constants.pathToPlotlyBuild)
5554
)
56-
.on('finish', function() {
57-
appendVersion(constants.pathToPlotlyBuild, {object: 'Plotly', DEV: true});
58-
});
5955
}
6056

6157
return bundle;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.