Replace browser-native dialogs with custom Datalab components #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
=======================================
Coverage 71.73% 71.73%
=======================================
Files 66 66
Lines 4482 4482
=======================================
Hits 3215 3215
Misses 1267 1267 🚀 New features to boost your workflow:
|
datalab
|
| Project |
datalab
|
| Branch Review |
bc/dialogs-modal
|
| Run status |
|
| Run duration | 09m 02s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
504
|
| View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1180
This PR replaces all browser-native alert and confirm dialogs (
window.confirm) with custom Datalab components.Uses a DialogService that manages dialogs and displays them through Vue components
Implemented 4 different modal styles to match various use cases: