compactor deletes corrupted blocks if chunks are missing #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
reviewed
Nov 27, 2025
pkg/compact/compact.go
Outdated
| // Validate chunk files exist in bucket before downloading. | ||
| // This catches corrupted blocks where meta.json references chunk files | ||
| // that were never uploaded or were deleted. | ||
| if err := block.ValidateBlockChunkFilesExist(ctx, cg.logger, cg.bkt, meta); err != nil { |
Collaborator
There was a problem hiding this comment.
this introduces additional overheads, how about handling error passive when the reference block isn't found instead of panicing.
jnyi
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see investigation doc
Changes
Verification