Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add a marker to indicate Python 3.10 isn't supported#33

Closed
kaxil wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
kaxil:patch-1Copy head branch name to clipboard
Closed

Add a marker to indicate Python 3.10 isn't supported#33
kaxil wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
kaxil:patch-1Copy head branch name to clipboard

Conversation

@kaxil

@kaxil kaxil commented Aug 17, 2022

Copy link
Copy Markdown

Currently, Python 3.10 isn't supported (GitHub Issue: #26), but as this marker here says it works for all Python version, if a user tries to install it on Py 3.10 it fails with unhelpful messages.

More about environment markers: https://peps.python.org/pep-0508/#environment-markers

@susodapop

Copy link
Copy Markdown
Contributor

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@susodapop

Copy link
Copy Markdown
Contributor

Also, agreed this should have been included in #27. That said, Python 3.10 support will be incorporated in the next release to Pypi. So changing this here isn't exactly necessary.

Currently, Python 3.10 isn't supported (GitHub Issue: #26), but as this marker here says it works for all Python version, if a user tries to install it on Py 3.10 it fails with unhelpful messages.

Signed-off-by: Kaxil Naik <kaxilnaik@gmail.com>
@kaxil

kaxil commented Aug 17, 2022

Copy link
Copy Markdown
Author

Thanks @susodapop , updated with signed commit message, Airflow Commiter and PMC member here 👋 . We are using this as dep for the Airflow-Databricks provider

Also, agreed this should have been included in #27. That said, Python 3.10 support will be incorporated in the next release to Pypi. So changing this here isn't exactly necessary.

Ideally, we you can release v2.0.4 with this change, this should help the current user making this mistake and then you can remove it when you actually add support for 3.10 in the next release.

@susodapop

Copy link
Copy Markdown
Contributor

NTMU 👋

Sorry what I meant to say is that we're working on releasing Python 3.10 support in v2.0.4 within a number of hours. We're just running the e2e tests for the change now. Making a special release with your proposed one-line change wouldn't happen measurably sooner.

@kaxil

kaxil commented Aug 17, 2022

Copy link
Copy Markdown
Author

NTMU 👋

Sorry what I meant to say is that we're working on releasing Python 3.10 support in v2.0.4 within a number of hours. We're just running the e2e tests for the change now. Making a special release with your proposed one-line change wouldn't happen measurably sooner.

Oh, that's awesome ❤️ . I didn't know you were planning 2.0.4 in few hours. That's good to know, we will hold off our release for astronomer/astronomer-providers#588 too 🚀

I will close this PR, thanks for you work

@kaxil kaxil closed this Aug 17, 2022
@kaxil kaxil deleted the patch-1 branch August 17, 2022 18:54
@susodapop

Copy link
Copy Markdown
Contributor

v2.0.4 is now live on Pypi 🚀

@kaxil

kaxil commented Aug 17, 2022

Copy link
Copy Markdown
Author

v2.0.4 is now live on Pypi 🚀

I can confirm it works for us now, thanks for the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.