Prepend slash to path if needed#27
Merged
kravets-levko merged 3 commits intoJul 12, 2022
databricks:masterdatabricks/databricks-sql-nodejs:masterfrom
kravets-levko:18-prepend-slash-to-pathCopy head branch name to clipboard
Merged
Prepend slash to path if needed#27kravets-levko merged 3 commits intodatabricks:masterdatabricks/databricks-sql-nodejs:masterfrom kravets-levko:18-prepend-slash-to-pathCopy head branch name to clipboard
kravets-levko merged 3 commits into
databricks:masterdatabricks/databricks-sql-nodejs:masterfrom
kravets-levko:18-prepend-slash-to-pathCopy head branch name to clipboard
Conversation
moderakh
reviewed
Jul 12, 2022
yunbodeng-db
previously approved these changes
Jul 12, 2022
|
|
||
| function prependSlash(str: string): string { | ||
| if (str.length > 0 && str.charAt(0) !== '/') { | ||
| return `/${str}`; |
Contributor
There was a problem hiding this comment.
I suppose there is no trimming business here? Someone has sanitized the path before?
Contributor
Author
There was a problem hiding this comment.
No trimming. Slash is required in path, so we just add it when missing; if it's already there - we do nothing
moderakh
approved these changes
Jul 12, 2022
This was referenced Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
First commit contains actual change, second one is
npm run build(we definitely should get rid of it)