UC Volume ingestion: uniform behavior on SQL REMOVE#249
Merged
kravets-levko merged 1 commit intoApr 19, 2024
maindatabricks/databricks-sql-nodejs:mainfrom
ingestion-remove-uniform-behaviordatabricks/databricks-sql-nodejs:ingestion-remove-uniform-behaviorCopy head branch name to clipboard
Merged
UC Volume ingestion: uniform behavior on SQL REMOVE#249kravets-levko merged 1 commit intomaindatabricks/databricks-sql-nodejs:mainfrom ingestion-remove-uniform-behaviordatabricks/databricks-sql-nodejs:ingestion-remove-uniform-behaviorCopy head branch name to clipboard
REMOVE#249kravets-levko merged 1 commit into
maindatabricks/databricks-sql-nodejs:mainfrom
ingestion-remove-uniform-behaviordatabricks/databricks-sql-nodejs:ingestion-remove-uniform-behaviorCopy head branch name to clipboard
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
benc-db
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks that AWS and Azure have a different behavior of HTTP
DELETEfor non-existing files.AWS assumes that - since file already doesn't exist - the goal is achieved, and returns HTTP 200.
Azure, on the other hand, is somewhat stricter and check if file exists before deleting it. And if
file doesn't exist - Azure returns HTTP 404.
For us, it's totally okay if file didn't exist before removing. So when we get an HTTP 404 -
just ignore it and report success. This way we can have a uniform library behavior for all clouds