Remove sqlparse.compat import#38
Merged
susodapop merged 1 commit intoApr 24, 2023
databricks:maindatabricks/databricks-sql-cli:mainfrom
kfollesdal:kfollesdal/sqlparse-compatkfollesdal/databricks-sql-cli:kfollesdal/sqlparse-compatCopy head branch name to clipboard
Merged
Remove sqlparse.compat import#38susodapop merged 1 commit intodatabricks:maindatabricks/databricks-sql-cli:mainfrom kfollesdal:kfollesdal/sqlparse-compatkfollesdal/databricks-sql-cli:kfollesdal/sqlparse-compatCopy head branch name to clipboard
susodapop merged 1 commit into
databricks:maindatabricks/databricks-sql-cli:mainfrom
kfollesdal:kfollesdal/sqlparse-compatkfollesdal/databricks-sql-cli:kfollesdal/sqlparse-compatCopy head branch name to clipboard
Conversation
sqlparse do no longer have sqlparse.compat. It was removed in version 0.4. It is missing from GitHub source and sqlparse-0.4.2.tar.gz from PyPI. But it exist in sqlparse-0.4.2-py3-none-any.whl from PyPi for some strang reasone. Since databricks-sql-cli import 'text_type' form sqlparse.compat it will faile if you install sqlparse in any other way other than wheel. sqlparse was remooved in the following commit: andialbrecht/sqlparse@3e3892f 'text_type' was replaced with 'str' so we do the same in databricks-sql-cli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparse do no longer have sqlparse.compat. It was removed in version 0.4. It is missing from GitHub source and sqlparse-0.4.2.tar.gz from PyPI. But it exist in sqlparse-0.4.2-py3-none-any.whl from PyPi for some strang reasone.
Since databricks-sql-cli import 'text_type' form sqlparse.compat it will faile if you install sqlparse in any other way other than wheel.
sqlparse was remooved in the following commit:
andialbrecht/sqlparse@3e3892f 'text_type' was replaced with 'str' so we do the same in databricks-sql-cli.