This repository was archived by the owner on Oct 21, 2022. It is now read-only.
D2-543 - Smart Art Basic XML Access #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just as a heads up, I ran a medium batch on our current Deckbot |
luna215
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot going on here. I'll try to give a basic run down but I honestly don't have a completely understanding of everything.
Smart Art objects are held in a Graphic Frame just like Charts and Tables. Like Charts, the smart art contents are stored in a different, related xml file. Unlike charts, this is actually 5 different XML files. 4 of those are referenced directly by the slide while the 5th (diagram.xml) is referenced from within the data.xml file.
My basic approach here was to get enough implementation that I could basically dump each of those 5 files into a string and then reproduce them with the batch tester. Ultimately, it worked pretty smoothly once I got it all worked out.
The most complicated part was retrieving and updating the reference to diagram.xml from within data.xml but I eventually got it.
This is also built so that it can work with D2-523 which makes it work with the slide importer.