Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT: mapping f-strings#136

Merged
honno merged 1 commit intodata-apis:masterdata-apis/array-api-tests:masterfrom
tylerjereddy:treddy_mapping_f_stringstylerjereddy/array-api-tests:treddy_mapping_f_stringsCopy head branch name to clipboard
Aug 10, 2022
Merged

MAINT: mapping f-strings#136
honno merged 1 commit intodata-apis:masterdata-apis/array-api-tests:masterfrom
tylerjereddy:treddy_mapping_f_stringstylerjereddy/array-api-tests:treddy_mapping_f_stringsCopy head branch name to clipboard

Conversation

@tylerjereddy
Copy link
Contributor

  • EqualityMapping was missing some f-strings that I needed
    while testing the conformance of the pykokkos library with
    the array API standard

* `EqualityMapping` was missing some f-strings that I needed
while testing the conformance of the `pykokkos` library with
the array API standard
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

On our end, it might be worth adding a (very conservatively configured) style linter to our pre-commit which can pick up on this kind of stuff.

@honno honno merged commit 4d9d7b4 into data-apis:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.