Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

flying-sheep
Copy link
Contributor

Companion PR to dask/distributed#9081

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±0        9 suites  ±0   3h 16m 0s ⏱️ + 3m 28s
 18 034 tests ±0   16 818 ✅ ±0   1 216 💤 ±0  0 ❌ ±0 
161 380 runs  ±0  149 246 ✅ ±0  12 134 💤 ±0  0 ❌ ±0 

Results for commit 4c33f5d. ± Comparison against base commit 87a177d.

@flying-sheep
Copy link
Contributor Author

test failures look unrelated

Copy link
Member

@guillaumeeb guillaumeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of removing this environment variable, but the change in distributed, and the way to configure them back should be documented.

docs/source/array-best-practices.rst Show resolved Hide resolved
docs/source/array-best-practices.rst Show resolved Hide resolved
@flying-sheep
Copy link
Contributor Author

yes, that’s what this PR is doing as it is.

@guillaumeeb
Copy link
Member

What I mean (and will try to explain better in dask/distributed#9081) is that how to set the correct configuration in a distributed setting should be added in distributed doc too, and point to this documentation from this part of the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.