Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore(build): 修改lombok依赖作用域为provided#198

Open
zhangyunan1994 wants to merge 1 commit intodashscope:maindashscope/dashscope-sdk-java:mainfrom
zhangyunan1994:mainzhangyunan1994/dashscope-sdk-java:mainCopy head branch name to clipboard
Open

chore(build): 修改lombok依赖作用域为provided#198
zhangyunan1994 wants to merge 1 commit intodashscope:maindashscope/dashscope-sdk-java:mainfrom
zhangyunan1994:mainzhangyunan1994/dashscope-sdk-java:mainCopy head branch name to clipboard

Conversation

@zhangyunan1994
Copy link

  • 将lombok依赖的scope从compile改为provided
  • 避免将lombok打包至最终产物中
  • 确保编译时注解处理器正常工作
  • 优化构建时依赖管理方式

- 将lombok依赖的scope从compile改为provided
- 避免将lombok打包至最终产物中
- 确保编译时注解处理器正常工作
- 优化构建时依赖管理方式
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在优化项目的构建时依赖管理。通过调整 lombok 依赖的作用域,项目确保 lombok 仅在编译和测试阶段可用,从而避免其被包含在最终的部署产物中。这种优化有助于减小最终构建的体积,并符合管理注解处理器库的最佳实践。

Highlights

  • 依赖作用域调整: 将 lombok 依赖的作用域从 compile 修改为 provided,以避免其被打包到最终产物中,同时确保编译时注解处理器正常工作。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次PR将Lombok的依赖作用域从compile修改为provided,这是一个正确的优化,可以避免将Lombok打包到最终的产物中,减小包体积。审查中,我发现pom.xml中的依赖版本管理方式有可以改进的地方,建议将版本号提取到<properties>中进行统一管理,以提高项目的可维护性。

@@ -59,7 +59,7 @@
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.26</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

为了提高可维护性并方便版本管理,建议将依赖项的版本号提取到 <properties> 标签中进行统一管理。这有助于确保版本一致性,并简化未来的升级过程。

例如,您可以在 <properties> 中定义 lombok.version,然后在此处引用它:

<properties>
    <maven.compiler.source>8</maven.compiler.source>
    <maven.compiler.target>8</maven.compiler.target>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <lombok.version>1.18.26</lombok.version>
    ...
</properties>

然后,此处的版本标签可以更新为使用该属性。对其他依赖项(如 junitslf4jokhttp 等)也推荐采用此方式。

Suggested change
<version>1.18.26</version>
<version>${lombok.version}</version>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.