Fix/add miss wan27 params#196
Fix/add miss wan27 params#196xiong-binbin merged 3 commits intodashscope:maindashscope/dashscope-sdk-java:mainfrom mose-x:fix/add_miss_wan27_paramsmose-x/dashscope-sdk-java:fix/add_miss_wan27_paramsCopy head branch name to clipboard
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the video synthesis functionality by introducing a new parameter to control audio handling. It provides more granular control over whether the generated video should include automatic audio, retain original audio, or have no audio, thereby increasing the flexibility and customization options for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new audioSetting parameter for video synthesis. The implementation is straightforward and aligns with the existing code structure. I have one suggestion to enhance the validation for the new parameter to avoid sending empty strings to the API. I also recommend adding unit tests for this new functionality to ensure it works as expected and to cover it against future changes.
| if (audioSetting != null) { | ||
| params.put(AUDIO_SETTING, audioSetting); | ||
| } |
There was a problem hiding this comment.
It's a good practice to also check if audioSetting is not an empty string before adding it to the parameters. This prevents sending potentially invalid empty values to the API. This is also consistent with how other string parameters like prompt are handled in getInput().
| if (audioSetting != null) { | |
| params.put(AUDIO_SETTING, audioSetting); | |
| } | |
| if (audioSetting != null && !audioSetting.isEmpty()) { | |
| params.put(AUDIO_SETTING, audioSetting); | |
| } |
No description provided.