fix continue as new bug where we missed router on the multi-app change#24
fix continue as new bug where we missed router on the multi-app change#24acroca merged 2 commits intodapr:maindapr/durabletask-python:mainfrom filintod:filinto/fix-continue-as-new-onlyfilintod/durabletask-python:filinto/fix-continue-as-new-onlyCopy head branch name to clipboard
Conversation
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
|
one thing is that this bug does not appear with durabletask-go, as it might not be aware of multi-app or don't care, so it would be better to change CI to run against real dapr setup |
|
@acroca this is important to have and then update 1.16 python to use it. we have this broken in 1.16 |
| result=shared.to_json(self._new_input) | ||
| if self._new_input is not None | ||
| else None, | ||
| result=shared.to_json(self._new_input) if self._new_input is not None else None, |
There was a problem hiding this comment.
To simplify this, I think it'd be better to move this to a variable like you did in the client.py.
Also change the other places where there's an inline if in function arguments, there are a few in this PR.
There was a problem hiding this comment.
not sure on the benefit of creating a new variable that is only used once, ternary operations assignments are common in python and already used in this file prior to this PR
There was a problem hiding this comment.
Right, maybe it's just a personal taste. It's fine
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
A slim version of #23 without linting, additions to tox, pyproject, removal of fluke8, etc