Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

vito
Copy link
Contributor

@vito vito commented Sep 28, 2024

Hi! Thanks a ton for making this package, I'm trying it out for midterm and it's been a breeze so far. Really happy replacing my janky parser, and to no longer have to scour the internet to figure out all these ancient escape sequences. 😄

I have an "interesting" test suite that runs against recorded htop and vim sessions and it's shaking out a few missing things here and there. In the case for this PR, I noticed it's possible to unset a mode, but not set one. Pattern-matched my way to a fix. 🙏

Signed-off-by: Alex Suraci <alex@dagger.io>
@danielgatis
Copy link
Owner

Wow! Thank you for your contribution. I created this library because I had a desire to write a terminal emulator in the future, but I never had the available time for that. I'm glad this code has helped you. I believe this code has never been truly used, so if you find more bugs or propose improvements, feel free to open more PRs. :)

@danielgatis danielgatis merged commit 69a2949 into danielgatis:main Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.