Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

vchernyshov
Copy link

This PR add support of BitBucketCloud support

Copy link
Member

@gianluz gianluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thank you very much for your PR!

@gianluz
Copy link
Member

gianluz commented Apr 16, 2022

Mind just add an entry to the CHANGELOG? Thank you very much!

@vchernyshov
Copy link
Author

@gianluz done)

@vchernyshov
Copy link
Author

@f-meloni do you have any estimate when it could be merged?

@f-meloni f-meloni merged commit 5601317 into danger:master Apr 26, 2022
@f-meloni
Copy link
Member

Merged! :)

@vchernyshov
Copy link
Author

@f-meloni cool) Can I get snapshot or beta version with BitBucket cloud support?

@f-meloni
Copy link
Member

@vchernyshov let me draft a release for it :)

@f-meloni
Copy link
Member

@vchernyshov 1.1.0 should be released now :)

@vchernyshov
Copy link
Author

@f-meloni thanks a lot!) one more question: how I can use models from danger-kotlin-library in my own plugin?

@f-meloni
Copy link
Member

@f-meloni thanks a lot!) one more question: how I can use models from danger-kotlin-library in my own plugin?

I think the simplest way is to pass the values to the function you use to invoke your plugin.

So if you have something like

package com.test.myawesomeplugin

import systems.danger.kotlin.sdk.DangerPlugin

object MyAwesomeDangerPlugin : DangerPlugin() {
    override val id: String
            get() = this.javaClass.name
    
    fun helloPlugin() {
        ...
    }
}

you can make helloPlugin take the values you need, for example the base branch name, and then pass it when you invoke it from Danger

  register plugin MyAwesomePlugin

  val danger = Danger(args)

  MyAwesomePlugin.helloPlugin(danger.github...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.