useFont/addFont with PDFontSupplier (FSSupplier<PDFont>) #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest official
This method allows to specify a FSSupplier<PDFont> that can either load a PDFont or serve an already loaded one to cut down on duplicate fonts/ subsets if the user is also writing directly to the PDDocument with some of the fonts used in the html.
Made PDFontSupplier (private static class in PdfBoxFontResolver) to actual class that can be subclassed if needed. Would have prefered to have a FSSupplier<PDFont> method in PdfBoxFontResolver but due to type-erasure error that is not possible. Added useFont(PDFontSupplier, ...) method to PdfRendererBuilder
|
Thanks a lot @DSW-PS. All looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @danfickle
this is the pr I offered in issue #383 .
As per your suggestion I also added the functionality as useFont methods to the PdfRendererBuilder.
I moved the already existing PDFontSupplier to a normal class so we can extend it - I would have prefered a useFont / addFont with direct FSSupplier but I wasn't too keen on reordering parameters just to clear the type-earasure error as it would clash with the useFont/addFont(FSSupplier ...) methods.