Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Oct 18, 2020. It is now read-only.

Conversation

pocketarc
Copy link

This will allow IDEs to show autocomplete information once you've got a valid method.

It might be worth adding @method statements as well, for better compatibility with IDEs, since @mixin might not be understood by some. If this PR is welcome, I'm happy to add that in as well.

@ghost
Copy link

ghost commented Jun 28, 2019

Hmm, I've always just used IDE Helper for that, and assumed other people would too...

Does this actually work, given that they need to be treated as static in the facade but are not static in the manager class?

Maybe for that reason listing the @methods, as you suggest, would be better... That seems to be what Laravel does. Downside is that's an extra thing to maintain, while IDE Helper does it automatically... But I guess I don't have any big plans to add new methods, so it's probably OK.

Thanks

@pocketarc
Copy link
Author

No, you're quite right - Laravel's IDE helper does obviate the need for this, and there's really no point maintaining @method declarations when you can have them autogenerated. I think it's worth closing this PR. Thanks for the quick response, sorry it ended up not being of more use!

@d13r
Copy link
Owner

d13r commented Jun 29, 2019

OK, thanks for the suggestion though 👍

@d13r d13r closed this Jun 29, 2019
@pocketarc pocketarc deleted the patch-1 branch June 29, 2019 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.