fix(cubestore): bind to 0.0.0.0 for statsd metrics to be able to send… #9922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dbb055 to
5bd9d27
Compare
… to non-localhost
5bd9d27 to
d00ef44
Compare
|
Bump on this quick PR, would be great if we can get this merged ASAP. Thanks! |
|
@ovr @waralexrom WDYT? |
|
@KSDaemon When do you think this PR will be merged? Waiting on this one to fix metrics issue in our self hosted deployment. |
KSDaemon
reviewed
Oct 15, 2025
| metrics_format, | ||
| vec![], | ||
| ); | ||
| init_metrics("0.0.0.0:0", metrics_server_address, metrics_format, vec![]); |
There was a problem hiding this comment.
@FlipEnergy I realized that in some cases exposing metrics via all [public] interfaces might have a security impact. So it would be much better to have this as a controlled option. Let's use an env with the default value of 127.0.0.1 with this. So those who need it (like you) may set the env to the desired value without impacting anyone else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to non-localhost
Check List
Issue Reference this PR resolves
Closes #9920