feat: Add query-time offset parameter for predefined granularities (implements #10042) #10054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for a query-time `offset` parameter on timeDimensions that allows shifting time boundaries for predefined granularities (day, week, month, etc.). This enables use cases like: - Days running 2am-2am instead of midnight-midnight - Weeks starting on Wednesday instead of Monday The offset parameter: - Only works with predefined granularities (day, week, month, etc.) - Throws a validation error if used with custom granularities - Uses SQL interval syntax (e.g., "2 hours", "-30 minutes", "2 days") - Is supported in REST API and GraphQL API Includes comprehensive unit and integration tests demonstrating the day-shifting and week-shifting use cases.
|
@hank-sq Please see my comment here: #10042 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#10042
Description of Changes Made (if issue reference is not provided)
Adds support for a query-time
offsetparameter on timeDimensions that allows shifting time boundaries for predefined granularities (day, week, month, etc.). This enables use cases like:The offset parameter:
Includes comprehensive unit and integration tests demonstrating the day-shifting and week-shifting use cases.