Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refact simulation: redundant use of pointers; log (stderr) -> print (stdout) #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

refact simulation: redundant use of pointers; log (stderr) -> print (stdout) #3889

merged 2 commits into from
Sep 12, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 12, 2025 •
edited
Loading

simplify code and reduce the odds of nil deref

@mmetc mmetc added this to the 1.7.1 milestone Sep 12, 2025
@github-actions GitHub Actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title refact cscli simulation: redundant use of pointers; log (strerr) -> p… refact cscli simulation: redundant use of pointers; log (stderr) -> print (stdout) Sep 12, 2025
@mmetc mmetc changed the title refact cscli simulation: redundant use of pointers; log (stderr) -> print (stdout) refact simulation: redundant use of pointers; log (stderr) -> print (stdout) Sep 12, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.63%. Comparing base (4e08b88) to head (890d207).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clisimulation/simulation.go 48.27% 12 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
+ Coverage   61.62%   61.63%   +0.01%     
==========================================
  Files         406      406              
  Lines       41874    41859      -15     
==========================================
- Hits        25806    25801       -5     
+ Misses      13945    13938       -7     
+ Partials     2123     2120       -3
Flag Coverage Δ
bats 45.69% <57.14%> (-0.02%) ⬇️
unit-linux 34.67% <17.14%> (+0.01%) ⬆️
unit-windows 24.57% <14.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc requested a review from sabban September 12, 2025 12:48
sabban
sabban approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 35a6f44 into master Sep 12, 2025
16 checks passed
@mmetc mmetc deleted the simulation branch September 12, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabban sabban sabban approved these changes

Assignees

No one assigned

Labels

kind/refactoring needs/area

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@mmetc @sabban
Morty Proxy This is a proxified and sanitized view of the page, visit original site.