Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refact pkg/parser: extract method processLeaves #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

refact pkg/parser: extract method processLeaves #3886

merged 3 commits into from
Sep 12, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 12, 2025

No description provided.

@mmetc mmetc added this to the 1.7.1 milestone Sep 12, 2025
@github-actions GitHub Actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.28%. Comparing base (075447c) to head (38f9550).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/parser/node.go 76.47% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3886      +/-   ##
==========================================
- Coverage   62.24%   57.28%   -4.96%     
==========================================
  Files         393      406      +13     
  Lines       40957    41874     +917     
==========================================
- Hits        25494    23988    -1506     
- Misses      13389    15840    +2451     
+ Partials     2074     2046      -28
Flag Coverage Δ
bats 45.70% <73.52%> (+0.02%) ⬆️
unit-linux ?
unit-windows 24.55% <76.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sabban
sabban approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 4e08b88 into master Sep 12, 2025
12 of 13 checks passed
@mmetc mmetc deleted the parser-leaves branch September 12, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabban sabban sabban approved these changes

Assignees

No one assigned

Labels

kind/refactoring needs/area

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@mmetc @sabban
Morty Proxy This is a proxified and sanitized view of the page, visit original site.