Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

lint: fix nilaway warnings (part 5) #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 22, 2025
Merged

lint: fix nilaway warnings (part 5) #3863

merged 5 commits into from
Sep 22, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 8, 2025

No description provided.

@mmetc mmetc added this to the 1.7.1 milestone Sep 8, 2025
@mmetc mmetc added the kind/enhancement New feature or request label Sep 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov Codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.64%. Comparing base (9dc77f2) to head (111931e).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/database/alerts.go 63.33% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   61.66%   61.64%   -0.02%     
==========================================
  Files         406      406              
  Lines       42001    42009       +8     
==========================================
  Hits        25898    25898              
- Misses      13976    13982       +6     
- Partials     2127     2129       +2
Flag Coverage Δ
bats 45.74% <67.64%> (+0.01%) ⬆️
unit-linux 34.65% <50.00%> (-0.02%) ⬇️
unit-windows 24.57% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc added kind/refactoring and removed kind/enhancement New feature or request labels Sep 8, 2025
@mmetc mmetc requested a review from sabban September 12, 2025 12:53
sabban
sabban reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed sth, but I see an issue with error management ?

cmd/crowdsec-cli/clihub/hub.go Show resolved Hide resolved
@mmetc mmetc requested a review from sabban September 22, 2025 08:33
LaurenceJJones
LaurenceJJones reviewed Sep 22, 2025
View reviewed changes
pkg/database/alerts.go Outdated Show resolved Hide resolved
sabban
sabban approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3e7a39a into master Sep 22, 2025
16 of 18 checks passed
@mmetc mmetc deleted the nil5 branch September 22, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabban sabban sabban approved these changes

@LaurenceJJones LaurenceJJones Awaiting requested review from LaurenceJJones

@blotus blotus Awaiting requested review from blotus

Assignees

No one assigned

Labels

kind/refactoring needs/area triage/accepted

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mmetc @sabban @LaurenceJJones
Morty Proxy This is a proxified and sanitized view of the page, visit original site.