Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

WAF: Improve user-experience with CRS and modsecurity rules #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 1, 2025
Merged

WAF: Improve user-experience with CRS and modsecurity rules #3827

merged 16 commits into from
Sep 1, 2025

Conversation

blotus
Copy link
Member

@blotus blotus commented Aug 26, 2025 •
edited
Loading

  • Use anomaly scores as the scenario name when a request is matched by the CRS (instead of a generic native_rule:ID)
  • Always track anomaly score
  • Exclude "internal" CRS rules from the matched rules
  • Use the log message as the scenario name when using a custom modsec rule

@github-actions GitHub Actions
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Aug 26, 2025

/kind enhancement
/area appsec

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.31638% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.59%. Comparing base (fce4091) to head (aa53f25).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/utils.go 75.00% 24 Missing and 7 partials ⚠️
pkg/types/appsec_event.go 46.66% 8 Missing ⚠️
pkg/appsec/appsec_rule/modsecurity.go 78.57% 4 Missing and 2 partials ⚠️
pkg/appsec/loader.go 0.00% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/cliitem/hubappsec.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3827      +/-   ##
==========================================
- Coverage   61.60%   61.59%   -0.02%     
==========================================
  Files         405      406       +1     
  Lines       41671    41850     +179     
==========================================
+ Hits        25672    25776     +104     
- Misses      13879    13941      +62     
- Partials     2120     2133      +13
Flag Coverage Δ
bats 45.62% <67.79%> (+0.06%) ⬆️
unit-linux 34.63% <68.36%> (+0.12%) ⬆️
unit-windows 24.52% <64.40%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

buixor
buixor reviewed Aug 26, 2025
View reviewed changes
pkg/acquisition/modules/appsec/utils.go Outdated Show resolved Hide resolved
buixor
buixor reviewed Aug 28, 2025
View reviewed changes
pkg/acquisition/modules/appsec/utils.go Outdated Show resolved Hide resolved
buixor
buixor reviewed Aug 28, 2025
View reviewed changes
pkg/acquisition/modules/appsec/utils.go Outdated Show resolved Hide resolved
@blotus blotus added this to the 1.7.0 milestone Aug 29, 2025
buixor
buixor reviewed Aug 29, 2025
View reviewed changes
pkg/acquisition/modules/appsec/utils.go Show resolved Hide resolved
LaurenceJJones
LaurenceJJones reviewed Sep 1, 2025
View reviewed changes
pkg/appsec/appsec_rule/modsecurity.go Outdated Show resolved Hide resolved
@blotus blotus merged commit c3036e2 into master Sep 1, 2025
20 of 21 checks passed
@blotus blotus deleted the improve-crs-use branch September 1, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buixor buixor buixor left review comments

@LaurenceJJones LaurenceJJones LaurenceJJones left review comments

@mmetc mmetc mmetc approved these changes

Assignees

No one assigned

Labels

area/appsec kind/enhancement New feature or request

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@blotus @buixor @LaurenceJJones @mmetc
Morty Proxy This is a proxified and sanitized view of the page, visit original site.