Include threads in the task list#2
Closed
alesax wants to merge 14 commits intocrash-python:mastercrash-python/crash-python:masterfrom
Closed
Include threads in the task list#2alesax wants to merge 14 commits intocrash-python:mastercrash-python/crash-python:masterfrom
alesax wants to merge 14 commits intocrash-python:mastercrash-python/crash-python:masterfrom
Conversation
There were some bare tabs lurking in there. Now it's just spaces as expected. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This moves the list handling to crash.types.list and accompanying infrastructure to crash.types.util so that it can be used elsewhere. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This commit defines a CrashArchitecture base class for architecture-specific code. We use it for implementing initial x86_64 support for thread handling. All that's required to add a new architecture is to drop in a $arch.py file in the crash/arch directory. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
The kernel data structures in the crash dump tell us which threads were active when the dump was taken but not the contents of those threads' registers. The dump format does contain that information so we need to access it from the vmcore attributes instead. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Initially, it just accepts a filename to set up a target. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Add a simple way to add commands. Initially, commands have a 'py' prefix. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
It interprets both new structured log format and old flat format logs. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This allows us to load the module whenever, but wait until we have the executable environment set up. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This patch will ultimately be split up but I'm committing for testing.
Changes in the upstream kdumpfile module mean that KDUMP_KVADDR is now a module constant and attributes are published directly instead of via the .attr() routine. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
We're getting to the point now where some caches would help, so this sets up the basic infrastructure. Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Author
|
Sorry, bad branch. |
jeffmahoney
pushed a commit
that referenced
this pull request
Jul 12, 2018
Without the patch, the backtrace displays the "cannot resolve stack trace" warning, dumps the backtrace, and then the text symbols: crash> bt PID: 0 TASK: f0962180 CPU: 6 COMMAND: "swapper/6" bt: cannot resolve stack trace: #0 [f095ff1c] __schedule at c0b6ef8d #1 [f095ff58] schedule at c0b6f4a9 #2 [f095ff64] schedule_preempt_disabled at c0b6f728 #3 [f095ff6c] cpu_startup_entry at c04b0310 #4 [f095ff94] start_secondary at c04468c0 bt: text symbols on stack: [f095ff1c] __schedule at c0b6ef8d [f095ff58] schedule at c0b6f4ae [f095ff64] schedule_preempt_disabled at c0b6f72d [f095ff6c] cpu_startup_entry at c04b0315 [f095ff94] start_secondary at c04468c5 crash> The backtrace shown is actually correct. (anderson@redhat.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads are currently not included within the list of tasks.
This stupid patch does that, by walking the thread_group of each task.