Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Harmonize the phrasing of "X models foo_of<Y>" #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

Quuxplusone
Copy link
Contributor

@Quuxplusone Quuxplusone commented May 19, 2024

This leaves at least two places that I don't know quite how to reword without major surgery; but it makes everything else consistent. The two places are

I started down this rabbit hole with [alg.equal], which currently says

the types of first1, last1, first2, and last2 pairwise model sized_sentinel_for ([iterator.concept.sizedsentinel])

which is obviously awkward since what it actually wants to say is that last1, first1 and last2, first2 model sized_sentinel_for — that's a weirdly reversed way of interpreting "pairwise". It now says simply "S1 models sized_sentinel_for<I1>"... but then I noticed all the random places where we said things like "S1 models sized_sentinel_for<S1, I1>" or "I1 and S1 model sized_sentinel_for<S1, I1>", and cleaned them up too.

The style being selected-for here is:

  • "I models input_iterator" (not "I models input_iterator<I>")
  • "S models sentinel_for<I>" (not "S models sentinel_for<S, I>"; not "S and I model sentinel_for")
  • "sentinel_for<S, I> is modeled" (only if absolutely necessary)

This leaves at least two places that I don't know quite how to
reword without major surgery; but it makes everything else consistent.
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.