Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

kubernetes: Allow upgrading existing node groups#205

Merged
themoriarti merged 1 commit intomaincozystack/cozystack:mainfrom
kubernetes-nodegroupscozystack/cozystack:kubernetes-nodegroupsCopy head branch name to clipboard
Jul 8, 2024
Merged

kubernetes: Allow upgrading existing node groups#205
themoriarti merged 1 commit intomaincozystack/cozystack:mainfrom
kubernetes-nodegroupscozystack/cozystack:kubernetes-nodegroupsCopy head branch name to clipboard

Conversation

@kvaps
Copy link
Member

@kvaps kvaps commented Jul 8, 2024

This PR introduces change to allow upgrading existing node groups for tenant Kubernetes cluster:

This fixes the error:

Status: Failed (UpgradeFailed: Helm upgrade failed for release tenant-test0/kubernetes-test0 with chart kubernetes@0.3.0: cannot patch "kubernetes-test0-md0" with kind KubevirtMachineTemplate: admission webhook "validation.kubevirtmachinetemplate.infrastructure.cluster.x-k8s.io" denied the request: KubevirtMachineTemplateSpec is immutable)

This is done by generating unique names for KubevirtMachineTemplate based on hash from spec. Old KubevirtMachineTemplates keep existing in the cluster until some MachineSet continues using them.

@kvaps kvaps changed the title kubernetes: Allow to upgrade existing node groups kubernetes: Allow upgrading existing node groups Jul 8, 2024
@kvaps kvaps force-pushed the kubernetes-nodegroups branch from c1a7900 to 4cf39c0 Compare July 8, 2024 16:34
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps force-pushed the kubernetes-nodegroups branch from 4cf39c0 to 0cf66bc Compare July 8, 2024 17:58
Copy link
Member

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@themoriarti themoriarti merged commit 9709059 into main Jul 8, 2024
@themoriarti themoriarti deleted the kubernetes-nodegroups branch July 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.