Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

cilium: enforce device detection and enable image building#151

Merged
kvaps merged 1 commit intomaincozystack/cozystack:mainfrom
fix-external-traffc-policycozystack/cozystack:fix-external-traffc-policyCopy head branch name to clipboard
May 27, 2024
Merged

cilium: enforce device detection and enable image building#151
kvaps merged 1 commit intomaincozystack/cozystack:mainfrom
fix-external-traffc-policycozystack/cozystack:fix-external-traffc-policyCopy head branch name to clipboard

Conversation

@kvaps
Copy link
Member

@kvaps kvaps commented May 26, 2024

This PR enables support forexternalTrafficPolicy: Cluster

Since cilium has no native method for dynamicaly configure the devices, we use bash script instead. For two reasons:

  1. to dynamicly find the device contains nodeIP
  2. to wait until ovn0 device start up

This PR includes the upstream fix:

https://github.com/aenix-io/cozystack/blob/750fe3a34afc5203dfec432684fa510210d5fd51/packages/system/cilium/patches/startup-script.patch

for more details see:

@kvaps kvaps changed the title fix external traffc policy fix externalTrafficPolicy: Cluster May 26, 2024
@kvaps kvaps force-pushed the fix-external-traffc-policy branch from 5038a2c to 9f955df Compare May 26, 2024 13:24
@kvaps kvaps marked this pull request as draft May 26, 2024 13:27
@kvaps kvaps force-pushed the fix-external-traffc-policy branch from 9f955df to 750fe3a Compare May 26, 2024 13:56
@kvaps
Copy link
Member Author

kvaps commented May 26, 2024

TODO: should also handle cases when user specified devices explicitly

packages/system/cilium/values.yaml Outdated Show resolved Hide resolved
@kvaps kvaps force-pushed the fix-external-traffc-policy branch from 750fe3a to 1058abe Compare May 27, 2024 15:58
@kvaps kvaps changed the title fix externalTrafficPolicy: Cluster cilium: enforce device detection and enable image building May 27, 2024
@kvaps kvaps requested a review from themoriarti May 27, 2024 17:08
@kvaps kvaps marked this pull request as ready for review May 27, 2024 17:11
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps force-pushed the fix-external-traffc-policy branch from 1058abe to 43f9540 Compare May 27, 2024 17:13
@themoriarti
Copy link
Member

Awesome patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.