[feat][backend] errorx StatusError with AffectStability #223
Conversation
| func TestWithExtra(t *testing.T) { | ||
| err := errorx.NewByCode(CommonInternalErrorCode) | ||
|
|
||
| statusErr, ok := errorx.FromStatusError(err) |
There was a problem hiding this comment.
这个是不是能在NewByCode的时候通过Option实现，不然New出来还要这么写，有点繁琐
There was a problem hiding this comment.
没有加到 new 方法中的原因是这样的：认为影响稳定性是在定义 code 时已经确定的属性，不应该更改；之前智伟你提到的 case 应该是下游抛出来的错误期望设置为不影响稳定性？
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 64.08% 64.03% -0.05%
==========================================
Files 477 477
Lines 51830 51834 +4
==========================================
- Hits 33214 33191 -23
- Misses 16286 16315 +29
+ Partials 2330 2328 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: