Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add simple C++ test #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shadinua merged 2 commits into from
Jun 4, 2020
Merged

Add simple C++ test #650

shadinua merged 2 commits into from
Jun 4, 2020

Conversation

@shadinua
Copy link
Contributor

@shadinua shadinua commented Jun 4, 2020

Builds a primitive C++ application using themis and soter libraries located at standard system paths. This allows us to check that Themis library and Themis C++ development environment have been properly installed on the target system.

# Build & run test
make test_cpp_simple
# Clean
make clean_themispp_simple_test

Yes, naming looks a bit strange, but now this is the approach taken in Makefiles. Hope we can improve it someday.

shadinua added 2 commits June 4, 2020 16:29
@shadinua
Add simple C++ test
6b807b2 
Builds a primitive C++ application using themis and soter libraries located at standard system paths. This allows us to check that Themis library and Themis C++ development environment have been properly installed on the target system.
@shadinua
Build fixes
10ab1df
@shadinua shadinua added the infrastructure Automated building and packaging label Jun 4, 2020
@shadinua shadinua requested review from Lagovas and ilammy June 4, 2020 14:14
@shadinua shadinua requested a review from vixentael as a code owner June 4, 2020 14:14
@shadinua shadinua self-assigned this Jun 4, 2020
ilammy
ilammy approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

But I still wonder if we are better off integrating docs/examples into the main Makefile. Some day.

(Also, it would be nice to get CircleCI/GHA to build this target too.)

tests/test.mk
include tests/tools/tools.mk
include tests/themis/themis.mk
include tests/themispp/themispp.mk
include tests/themispp_simple/themispp_simple.mk
Copy link
Collaborator

@ilammy ilammy Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I remember that RustThemis has some special relationship with included Makefiles, but this should be okay because tests/test.mk is not included when building by Cargo:

themis/Makefile

Lines 363 to 370 in a558d85

ifndef CARGO
include src/wrappers/themis/jsthemis/jsthemis.mk
include src/wrappers/themis/themispp/themispp.mk
include src/wrappers/themis/wasm/wasmthemis.mk
include jni/themis_jni.mk
include tests/test.mk
include tools/afl/fuzzy.mk
endif

@shadinua shadinua merged commit 63d7362 into master Jun 4, 2020
@shadinua shadinua deleted the shadinua/test_cpp_simple branch June 4, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilammy ilammy ilammy approved these changes

@Lagovas Lagovas Lagovas approved these changes

@vixentael vixentael Awaiting requested review from vixentael vixentael is a code owner

Assignees

@shadinua shadinua

Labels

infrastructure Automated building and packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shadinua @ilammy @Lagovas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.