Correct data corruption tests #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "256 - byte" with "~byte" as an example of data corruption. I don't know what the person writing that thought, but if the byte happens to be equal exactly 128 then 256 - 128 = 128, nothing gets corrupted, and the tests fail. They do occasionally fail, when the stars are just right, this was attributed to some issue in the token parsers of Secure Cell which ignored some of the bytes. Now all that code has been updated to be more strict so *any* changes in the data should be reliably detected and result in a failure.
vixentael
approved these changes
Mar 26, 2020
Contributor
vixentael
left a comment
There was a problem hiding this comment.
Don’t be so hard on yourself 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
256 - bytewith~byteas an example of data corruption. I don't know what the person writing that was thinking, but if the byte happens to be equal exactly 128 then 256 – 128 = 128, nothing gets corrupted, and the tests fail. They do occasionally fail, when the stars are just right, this was attributed to some issue in the token parsers of Secure Cell which ignored some of the bytes. Now all that code has been updated to be more strict so any changes in the data should be reliably detected and result in a failure.Checklist