Run ThemisPP tests with C++14 and C++17 #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly test compatibility with those standard levels. C++20 is currently being finalized. It's somewhat supported in the compilers, but not in the versions shipped with Ubuntu 16.04.
vixentael
approved these changes
Dec 23, 2019
It turned out that behavior wrt attributes might be different between GCC and Clang, so let's test both compilers now. Clang that we have in the Docker image does not support "-std=c++17", so we do not test with that. (Actually, GCC support the option, but __cplusplus value suggests that it's still in C++14 mode.)
vixentael
approved these changes
Dec 24, 2019
Contributor
vixentael
left a comment
There was a problem hiding this comment.
more tests to the god of tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We boast in the docs about C++14 being “tested and supported“ so we’d better do that :) Explicitly test compatibility with C++14 and C++17.
C++20 is currently being finalized. It's somewhat supported in the compilers, but not in the versions shipped with Ubuntu 16.04.
Checklist
Benchmark results are attachedPublic API has proper documentationExample projects and code samples are updated