Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add the as property in the CFooter component to use semantic tag #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion 9 packages/coreui-vue/src/components/footer/CFooter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import { defineComponent, h } from 'vue'
const CFooter = defineComponent({
name: 'CFooter',
props: {
/**
* Component used for the root node. Either a string to use a HTML element or a component.
*/
as: {
type: String,
default: 'div',
},
/**
* Place footer in non-static positions.
*
Expand All @@ -18,7 +25,7 @@ const CFooter = defineComponent({
setup(props, { slots }) {
return () =>
h(
'div',
props.as,
{ class: ['footer', { [`footer-${props.position}`]: props.position }] },
slots.default && slots.default(),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ const customWrapper = mount(Component, {
},
})

const customWrapperTwo = mount(Component, {
propsData: {
as: 'footer',
},
slots: {
default: 'Default slot',
},
})

describe(`Loads and display ${ComponentName} component`, () => {
it('has a name', () => {
expect(Component.name).toMatch(ComponentName)
Expand All @@ -42,3 +51,13 @@ describe(`Customize ${ComponentName} component`, () => {
expect(customWrapper.classes('footer-fixed')).toBe(true)
})
})

describe(`Customize (number two) ${ComponentName} component`, () => {
it('renders correctly', () => {
expect(customWrapperTwo.html()).toMatchSnapshot()
})

it('tag name is custom', () => {
expect(customWrapperTwo.element.tagName).toBe('FOOTER')
})
})
Morty Proxy This is a proxified and sanitized view of the page, visit original site.