refactor: replace str-index() with string.index(), str-length()…

… with `string.length()`, `str-slice()` with `string.slice()`, and `quote()` with `string.quote()`
coreui · mrholek · Jan 30, 2025 · Jan 11, 2025 · Jan 13, 2025 · Jan 13, 2025
commit 06ab8a93ab5070a4e583aa669afb88fb8b77ae7c
diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -1,4 +1,5 @@
 @use "sass:color";
+@use "sass:string";
 @use "functions/assert" as *;
 @use "functions/color" as *;
 @use "functions/math" as *;
@@ -1842,7 +1843,7 @@ $breadcrumb-margin-bottom:          1rem !default;
 $breadcrumb-bg:                     null !default;
 $breadcrumb-divider-color:          var(--#{$prefix}secondary-color) !default;
 $breadcrumb-active-color:           var(--#{$prefix}secondary-color) !default;
-$breadcrumb-divider:                quote("/") !default;
+$breadcrumb-divider:                string.quote("/") !default;
 $breadcrumb-divider-flipped:        $breadcrumb-divider !default;
 $breadcrumb-border-radius:          null !default;
 // scss-docs-end breadcrumb-variables

diff --git a/scss/functions/_escape-svg.scss b/scss/functions/_escape-svg.scss
@@ -1,3 +1,4 @@
+@use "sass:string";
 @use "../variables" as *;
 @use "str-replace" as *;

@@ -6,11 +7,11 @@
 // Requires the use of quotes around data URIs.

 @function escape-svg($string) {
-  @if str-index($string, "data:image/svg+xml") {
+  @if string.index($string, "data:image/svg+xml") {
    @each $char, $encoded in $escaped-characters {
      // Do not escape the url brackets
-      @if str-index($string, "url(") == 1 {
-        $string: url("#{str-replace(str-slice($string, 6, -3), $char, $encoded)}");
+      @if string.index($string, "url(") == 1 {
+        $string: url("#{str-replace(string.slice($string, 6, -3), $char, $encoded)}");
      } @else {
        $string: str-replace($string, $char, $encoded);
      }

diff --git a/scss/functions/_str-replace.scss b/scss/functions/_str-replace.scss
@@ -1,3 +1,4 @@
+@use "sass:string";
 // Replace `$search` with `$replace` in `$string`
 // Used on our SVG icon backgrounds for custom forms.
 //
@@ -7,10 +8,10 @@
 // @param {String} $replace ('') - New value
 // @return {String} - Updated string
 @function str-replace($string, $search, $replace: "") {
-  $index: str-index($string, $search);
+  $index: string.index($string, $search);

  @if $index {
-    @return str-slice($string, 1, $index - 1) + $replace + str-replace(str-slice($string, $index + str-length($search)), $search, $replace);
+    @return string.slice($string, 1, $index - 1) + $replace + str-replace(string.slice($string, $index + string.length($search)), $search, $replace);
  }

  @return $string;

diff --git a/scss/mixins/_ltr-rtl.scss b/scss/mixins/_ltr-rtl.scss
@@ -20,10 +20,10 @@

 @function reflect($element) {
  $string: #{$element};
-  @if str-index($string, "left") {
+  @if string.index($string, "left") {
    @return str-replace($string, "left", "right");
  }
-  @if str-index($string, "right") {
+  @if string.index($string, "right") {
    @return str-replace($string, "right", "left");
  }


diff --git a/scss/mixins/_utilities.scss b/scss/mixins/_utilities.scss
@@ -1,6 +1,7 @@
 @use "sass:list";
 @use "sass:map";
 @use "sass:meta";
+@use "sass:string";
 @use "../variables" as *;
 @use "../vendor/rfs" as *;
 @use "ltr-rtl" as *;
@@ -38,7 +39,7 @@
    // State params to generate pseudo-classes
    $state: if(map.has-key($utility, state), map.get($utility, state), ());

-    $infix: if($property-class == "" and str-slice($infix, 1, 1) == "-", str-slice($infix, 2), $infix);
+    $infix: if($property-class == "" and string.slice($infix, 1, 1) == "-", string.slice($infix, 2), $infix);

    // Don't prefix if value key is null (e.g. with shadow class)
    $property-class-modifier: if($key, if($property-class == "" and $infix == "", "", "-") + $key, "");

diff --git a/scss/vendor/_rfs.scss b/scss/vendor/_rfs.scss
@@ -222,7 +222,7 @@ $rfs-mq-property-height: if($rfs-mode == max-media-query, max-height, min-height
  }

  // Remove first space
-  @return string.unquote(str-slice($val, 2));
+  @return string.unquote(string.slice($val, 2));
 }

 // Helper function to get the responsive value calculated by RFS
@@ -278,7 +278,7 @@ $rfs-mq-property-height: if($rfs-mode == max-media-query, max-height, min-height
  }

  // Remove first space
-  @return string.unquote(str-slice($val, 2));
+  @return string.unquote(string.slice($val, 2));
 }

 // RFS mixin