Rebuild & rename aht-dummy rpm to coreos-dummy #4098

aaradhak · May 8, 2025

Resolves issues related to the dummy RPM used in kola tests
(ostree.unlock, ostree.hotfix) which failed with a "no digest"
error after a system rpm upgrade (to rpm 5.99.90-2.fc43).

Changes in this commit:

Renamed aht-dummy.spec to coreos-dummy.spec and rebuilt the rpm.
Updated the rpm 'Name' tag within the spec file to coreos-dummy.
This addresses the outdated "aht-dummy" naming as used in Atomic Host
repository which is no longer active

Ref: coreos/fedora-coreos-tracker#1929

mantle/kola/tests/ostree/unlock.go

dustymabe · May 8, 2025

mantle/kola/tests/rpmostree/deployments.go

 					"verification": {
-					  "hash": "sha512-da29ae637b30647cab2386a2ce6b4223c3ad7120ae8dd32d9ce275f26a11946400bba0b86f6feabb9fb83622856ef39f8cecf14b4975638c4d8c0cf33b0f7b26"
+					  "hash": "sha512-265ab9d1e4a5dd1b0277b9c014fa72ba4cced7bad2796d89a89b303bb233545dc9fe41917da6339c60776b1abb0281317ebea760c0f8e70916f73830d0eca10f"


we might have to update this periodically. Maybe it would be better to not include it?

@jlebon WDYT?

I don't think that aspect is relevant to the test, so SGTM.

@aaradhak - drop the verification section here since we don't want this to fail if the RPM gets updated.

mantle/kola/tests/rpmostree/deployments.go

dustymabe · May 13, 2025

mantle/kola/tests/rpmostree/deployments.go

-	var ahtRpmPath = "/var/home/core/aht-dummy.rpm"
-	var installPkgName = "aht-dummy-1.0-1.noarch"
-	var installBinName = "aht-dummy"
+	var epelRpmPath = "/var/home/core/epel-release-latest-9.noarch.rpm"


we need to update the sudo rpm-ostree install below to use this variable.

I have updated it

dustymabe · May 13, 2025

mantle/kola/tests/ostree/unlock.go

-	rpmUrl  string = "https://raw.githubusercontent.com/projectatomic/atomic-host-tests/master/rpm/aht-dummy-1.0-1.noarch.rpm"
-	rpmName string = "aht-dummy"
+	rpmUrl  string = "https://dl.fedoraproject.org/pub/epel/"
+	rpmName string = "epel-release"
 )


you'll probably need to remove the command -v tests below because this RPM doesn't provide any binaries.

removed the unnecessary binary related variables

mantle/kola/tests/rpmostree/deployments.go

dustymabe · May 13, 2025

mantle/kola/tests/rpmostree/deployments.go

-	var installPkgName = "aht-dummy-1.0-1.noarch"
-	var installBinName = "aht-dummy"
+	var epelRpmPath = "/var/home/core/epel-release-latest-9.noarch.rpm"
+	var installPkgName = "epel-release-latest-9.noarch.rpm"


Suggested change

var installPkgName = "epel-release-latest-9.noarch.rpm"

var installPkgName = "epel-release"

The name of the RPM is epel-release

dustymabe · May 13, 2025

Please rebase this on top of latest :main when you do a new upload here.

aaradhak · May 14, 2025

We are getting a CI error with epel-release-9-10.el9.noarch.rpm - its a dependency error. May be we should try with a different epel-release rpm version ? I will try to see if epel-release-latest-8.noarch.rpm makes a difference

CI error :

[2025-05-14T21:04:54.608Z]     --- FAIL: ostree.unlock/install (0.20s)

[2025-05-14T21:04:54.608Z]             cluster.go:151: warning: /var/tmp/rpm-tmp.u8TtqM: Header V4 RSA/SHA256 Signature, key ID 3228467c: NOKEY

[2025-05-14T21:04:54.608Z]             cluster.go:151: error: Failed dependencies:

[2025-05-14T21:04:54.608Z]             cluster.go:151: 	redhat-release >= 9 is needed by epel-release-9-10.el9.noarch

[2025-05-14T21:04:54.608Z]             cluster.go:151: 	fedora-release conflicts with epel-release-9-10.el9.noarch

[2025-05-14T21:04:54.608Z]             unlock.go:147: Failed to install RPM: Process exited with status 1

aaradhak · May 14, 2025

I dont think epel-release-latest-8.noarch.rpm makes a difference here.

[2025-05-14T22:13:10.481Z]     --- FAIL: ostree.unlock/install (0.23s)

[2025-05-14T22:13:10.481Z]             cluster.go:151: warning: /var/tmp/rpm-tmp.qPkyTE: Header V4 RSA/SHA256 Signature, key ID 2f86d6a1: NOKEY

[2025-05-14T22:13:10.481Z]             cluster.go:151: error: Failed dependencies:

[2025-05-14T22:13:10.481Z]             cluster.go:151: 	redhat-release >= 8 is needed by epel-release-8-22.el8.noarch

[2025-05-14T22:13:10.481Z]             cluster.go:151: 	fedora-release conflicts with epel-release-8-22.el8.noarch

[2025-05-14T22:13:10.481Z]             unlock.go:147: Failed to install RPM: Process exited with status 1

dustymabe · May 21, 2025

mantle/kola/tests/ostree/unlock.go

@@ -44,8 +44,8 @@ func init() {
 }

 var (
-	rpmUrl  string = "https://raw.githubusercontent.com/projectatomic/atomic-host-tests/master/rpm/aht-dummy-1.0-1.noarch.rpm"
-	rpmName string = "aht-dummy"
+	rpmUrl  string = "https://mirrors.rpmfusion.org/free/fedora/rpmfusion-free-release-rawhide.noarch.rpm"


You can't just use the rawhide RPM on F42 (testing-devel) so you'd have to conditionalize everything. I'd say at this point let's just try to build the dummy rpm again in a new dedicated repo for that purpose.

I see, I tried with the rawhide rpm as this failure is happening in rawhide branch as well. I have made a new repo for aht-dummy-rpm and rebuilt the rpm. I will make the update here and try again

aaradhak · May 21, 2025

With the rpm-fusion-rawhide pkg , looks like it it is dependent on another pkg. The kola tests failed because it attempted to install rpm-fusion package that has a dependency system-release(43)

dustymabe · May 21, 2025

With the rpm-fusion-rawhide pkg , looks like it it is dependent on another pkg. The kola tests failed because it attempted to install rpm-fusion package that has a dependency system-release(43)

Yes. By design the current rawhide package will only work on Fedora 43 (rawhide is currently Fedora 43).

aaradhak · May 21, 2025

With the rpm-fusion-rawhide pkg , looks like it it is dependent on another pkg. The kola tests failed because it attempted to install rpm-fusion package that has a dependency system-release(43)

Yes. By design the current rawhide package will only work on Fedora 43 (rawhide is currently Fedora 43).

Do we need to look for a pkg without any dependency?

dustymabe · May 21, 2025

Do we need to look for a pkg without any dependency?

Either that (i.e. find a package that works everywhere, which will probably only find if we build it) or dynamically update the test based on the target we are testing against.

At this point I'm voting we revive the dummy package.

aaradhak · May 21, 2025

ok, I will look into adding the aht-dummy pkg by creating a new repo.

aaradhak · May 29, 2025

Created a new aht-dummy-repo and updated the aht-dummy-rpm build

dustymabe · May 29, 2025

Created a new aht-dummy-repo and updated the aht-dummy-rpm build

Sorry to bikeshed on the name.. Could we give it a more descriptive name now?

aht stands for "Atomic Host Tests" and Atomic Host is dead, so the name doesn't make much sense anymore either.
The word repo could be confusing too, because this doesn't actually host a yum repo. It's just the RPM file.

WDYT about renaming the git repo (which should be easy to do) to: coreos-dummy-rpm?

aaradhak · May 29, 2025

Created a new aht-dummy-repo and updated the aht-dummy-rpm build

Sorry to bikeshed on the name.. Could we give it a more descriptive name now?

aht stands for "Atomic Host Tests" and Atomic Host is dead, so the name doesn't make much sense anymore either.

The word repo could be confusing too, because this doesn't actually host a yum repo. It's just the RPM file.

WDYT about renaming the git repo (which should be easy to do) to: coreos-dummy-rpm?

Sure, I can make that change in the name

aaradhak · May 29, 2025

@dustymabe I have updated the repo name ro coreos-dummy-rpm https://github.com/coreos/coreos-dummy-rpm , I have created a release tag too for this - https://github.com/coreos/coreos-dummy-rpm/releases/tag/v1.0.0

dustymabe · May 29, 2025

@dustymabe I have updated the repo name ro coreos-dummy-rpm https://github.com/coreos/coreos-dummy-rpm , I have created a release tag too for this - https://github.com/coreos/coreos-dummy-rpm/releases/tag/v1.0.0

Nice. So here's what I would do next:

rename the actual spec file (and also the name inside the spec file) to coreos-dummy instead of aht-dummy.

The following could be done, but it's optional as it provides only marginal benefit/gain:

delete the actual *rpm file from git
commit that and tag it with v2.0.0
build the RPM and then attach the .rpm file to the v2.0.0 release (i.e. edit the release and attach binaries to it).

Resolves issues related to the dummy RPM used in kola tests (ostree.unlock, ostree.hotfix) which failed with a "no digest" error after a system rpm upgrade (to rpm 5.99.90-2.fc43). Changes in this commit: - Renamed aht-dummy.spec to coreos-dummy.spec and rebuilt the rpm. - Updated the rpm 'Name' tag within the spec file to coreos-dummy. - This addresses the outdated "aht-dummy" naming as used in Atomic Host repository which is no longer active

aaradhak · May 30, 2025

I have updated the spec file to carry the name coreos-dummy instead of aht-dummy. I have also built the rpm again and updated the release to v2.0.0 - https://github.com/coreos/coreos-dummy-rpm/releases/tag/V2.0.0

dustymabe

LGTM

dustymabe · May 30, 2025

Thanks for working on this!

The fix for kola tests (ostree.unlock, ostree.hotfix) which failed with a "no digest" error after a system rpm upgrade to rpm-5.99.90-2.fc43 has merged. We can now unpin the rpm-4.20.1-3.fc43 Ref: coreos/coreos-assembler#4098

aaradhak changed the title ~~Change aht-dummy rpm test~~ Replace aht-dummy rpm epel-release-latest rpm May 8, 2025

dustymabe reviewed May 8, 2025

View reviewed changes

mantle/kola/tests/ostree/unlock.go Outdated Show resolved Hide resolved

dustymabe reviewed May 8, 2025

View reviewed changes

jlebon reviewed May 9, 2025

View reviewed changes

mantle/kola/tests/rpmostree/deployments.go Show resolved Hide resolved

aaradhak force-pushed the ostreehotfix branch from c79c3b7 to 7afa82f Compare May 12, 2025 23:14

dustymabe reviewed May 13, 2025

View reviewed changes

mantle/kola/tests/rpmostree/deployments.go Outdated Show resolved Hide resolved

dustymabe reviewed May 13, 2025

View reviewed changes

aaradhak requested a review from dustymabe May 13, 2025 19:45

aaradhak force-pushed the ostreehotfix branch 3 times, most recently from 06db570 to 01d0339 Compare May 13, 2025 20:05

aaradhak changed the title ~~Replace aht-dummy rpm epel-release-latest rpm~~ Replace aht-dummy with epel-release-latest rpm May 13, 2025

aaradhak force-pushed the ostreehotfix branch from 2f04665 to 1147135 Compare May 14, 2025 20:23

dustymabe reviewed May 21, 2025

View reviewed changes

aaradhak requested a review from dustymabe May 29, 2025 16:21

aaradhak changed the title ~~Replace aht-dummy with epel-release-latest rpm~~ Replace aht-dummy with coreos-dummy rpm May 29, 2025

aaradhak force-pushed the ostreehotfix branch from 65d248d to 5fbaf04 Compare May 29, 2025 22:24

aaradhak changed the title ~~Replace aht-dummy with coreos-dummy rpm~~ Rebuild & rename aht-dummy rpm to coreos-dummy May 29, 2025

dustymabe approved these changes May 30, 2025

View reviewed changes

dustymabe merged commit 9f53ced into coreos:main May 30, 2025
5 checks passed

This was referenced May 30, 2025

[rawhide] overrides: unpin rpm-4.20.1-3.fc43 coreos/fedora-coreos-config#3527

Merged

[rawhide][x86_64] ostree.unlock & ostree.hotfix tests failure coreos/fedora-coreos-tracker#1929

Closed

	var installPkgName = "epel-release-latest-9.noarch.rpm"
	var installPkgName = "epel-release"

Search code, repositories, users, issues, pull requests...

Rebuild & rename aht-dummy rpm to coreos-dummy #4098

Rebuild & rename aht-dummy rpm to coreos-dummy #4098

Uh oh!

Conversation

aaradhak commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dustymabe May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dustymabe commented May 13, 2025

Uh oh!

aaradhak commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaradhak commented May 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaradhak commented May 21, 2025

Uh oh!

dustymabe commented May 21, 2025

Uh oh!

aaradhak commented May 21, 2025

Uh oh!

dustymabe commented May 21, 2025

Uh oh!

aaradhak commented May 21, 2025

Uh oh!

aaradhak commented May 29, 2025

Uh oh!

dustymabe commented May 29, 2025

Uh oh!

aaradhak commented May 29, 2025

Uh oh!

aaradhak commented May 29, 2025

Uh oh!

dustymabe commented May 29, 2025

Uh oh!

aaradhak commented May 30, 2025

Uh oh!

dustymabe left a comment

Choose a reason for hiding this comment

Uh oh!

dustymabe commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

aaradhak commented May 8, 2025 •

edited

Loading

dustymabe May 13, 2025 •

edited

Loading

aaradhak commented May 14, 2025 •

edited

Loading