Add encoding to os version and features#28
Merged
samuelkarp merged 1 commit intocontainerd:maincontainerd/platforms:mainfrom Mar 19, 2026
Merged
Add encoding to os version and features#28samuelkarp merged 1 commit intocontainerd:maincontainerd/platforms:mainfrom
samuelkarp merged 1 commit intocontainerd:maincontainerd/platforms:mainfrom
Conversation
Prevent os version or features containing characters which are used for formatting from creating invalid output. The character set to be encoded is small and likely rarely used, but include to prevent compatibility issues in the future or creating unintended limits on the values. Signed-off-by: Derek McGowan <derek@mcg.dev>
samuelkarp
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent os version or features containing characters which are used for formatting from creating invalid output. The character set to be encoded is small and likely rarely used, but include to prevent compatibility issues in the future or creating unintended limits on the values.
I want to get this in before the next rc. With this encoding added, there should be no more concerns over this package defining limits on the values or need to debate on compatibility with OCI spec.