Updating testParametersContainingSubDefinitions#5
Open
moufmouf wants to merge 1 commit intomastercontainer-interop/definition-interop-tests:masterfrom
fix-sub-definitions-testcontainer-interop/definition-interop-tests:fix-sub-definitions-testCopy head branch name to clipboard
Open
Updating testParametersContainingSubDefinitions#5moufmouf wants to merge 1 commit intomastercontainer-interop/definition-interop-tests:masterfrom fix-sub-definitions-testcontainer-interop/definition-interop-tests:fix-sub-definitions-testCopy head branch name to clipboard
moufmouf wants to merge 1 commit intomastercontainer-interop/definition-interop-tests:masterfrom
fix-sub-definitions-testcontainer-interop/definition-interop-tests:fix-sub-definitions-testCopy head branch name to clipboard
Conversation
I removed the `"foo"=>"bar"` part of the definitions array. A DefinitionProvider should return an array of `DefinitionInterface`, indexed by key. `"bar"` is not a valid `DefinitionInterface`. Note: the `ArrayDefinitionProvider` used in this test is NOT the one from Assembly (that wraps values not implementing the `DefinitionInterface` into `ParameterDefinition` objects). It is one I wrote for the tests that does pass the array "as is".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the
"foo"=>"bar"part of the definitions array.A DefinitionProvider should return an array of
DefinitionInterface, indexed by key."bar"is not a validDefinitionInterface.Note: the
ArrayDefinitionProviderused in this test is NOT the one from Assembly (that wraps values not implementing theDefinitionInterfaceintoParameterDefinitionobjects). It is one I wrote for the tests that does pass the array "as is".