DGS-20678 Fix possible NPE in CSFLE executor #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a potential None reference issue in the CSFLE executor by ensuring that self.config is always set to a dictionary.
- Adds a branch to initialize self.config to an empty dictionary if rule_conf is not provided and self.config is None.
- Helps prevent runtime errors when accessing self.config.
src/confluent_kafka/schema_registry/rules/encryption/encrypt_executor.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: confluent-kafka-python |
Claimundefine
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups