-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
GLOB_BRACE is not defined on all platforms #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
should we also detect the usage of braces in the glob, and fail loudly if trying to use such path repository on a platform not supporting it ? |
Not sure we can detect the braces, as the regex could also contain e.g. |
What do you mean? |
Ohh .. you are right... mixed things up. |
Symfony uses |
If you could add that check, would very much appreciate it :-) |
Here we go |
LGTM. @stof ? |
Thanks guys |
Should address #7444 (comment)