Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix BC of generated static map #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented Jan 4, 2018

This needs an emergency release, as it breaks using legacy class-loader, like the one bundled into phpunit.
ping @Seldaek

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Any details on what/how it breaks? Just trying to understand here..

@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Jan 4, 2018

How: see https://travis-ci.org/symfony/symfony/jobs/324996450
Why: missing prefixLengthsPsr4 map in newly dumped static map breaks the ClassLoader provided by phpunit (old one)

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

I see.. but I am not sure if the fix will really fix it then. What if you dump a completely new loader into that dir (so it won't add the prefixLengthsPsr4 at all) and then phpunit will break?

@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Jan 4, 2018

What about reverting 3be9591 then?
With static arrays in shared memory, the gain is non existent anyway.

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Yeah I think that might be the only way forward. It sucks that we basically can't make any change to this code though with the static array. I'll work on a partial revert as we can still keep some of the changes.

@nicolas-grekas
Copy link
Contributor Author

(revert pushed)

@nicolas-grekas
Copy link
Contributor Author

I'll work on a partial revert as we can still keep some of the changes

already done here :)

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Yup I see, sorry have 5 things going on atm :/ Looks good to me except I don't know if it'll break people that upgraded to 1.6.0 and already dumped a new autoloader.. Maybe we need reverse-BC code?

@nicolas-grekas nicolas-grekas force-pushed the fix-autoloader branch 2 times, most recently from 3f2fe70 to cb0f89f Compare January 4, 2018 13:10
@nicolas-grekas
Copy link
Contributor Author

Here we are.

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Thanks.. Let's hope no further adverse effect.

@Seldaek Seldaek merged commit ebc3c7d into composer:1.6 Jan 4, 2018
@nicolas-grekas nicolas-grekas deleted the fix-autoloader branch January 4, 2018 13:13
@nicolas-grekas
Copy link
Contributor Author

I beg for a new tag please :)

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Yes yes sorry everything is on fire right now, on it ASAP

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Also why are you the only one affected here? Anything special symfony is doing? I just wonder why travis builds haven't caught fire everywhere.

@nicolas-grekas
Copy link
Contributor Author

I think it's because of a cached ClassLoader that were compiled when symfony/phpunit-bridge compiled its variant of phpunit. There must be some unusual autoloader loading logic there.

@Seldaek
Copy link
Member

Seldaek commented Jan 4, 2018

Ok 1.6.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.