-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix BC of generated static map #6973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any details on what/how it breaks? Just trying to understand here.. |
How: see https://travis-ci.org/symfony/symfony/jobs/324996450 |
I see.. but I am not sure if the fix will really fix it then. What if you dump a completely new loader into that dir (so it won't add the |
What about reverting 3be9591 then? |
Yeah I think that might be the only way forward. It sucks that we basically can't make any change to this code though with the static array. I'll work on a partial revert as we can still keep some of the changes. |
(revert pushed) |
already done here :) |
12b32a7
to
50a3786
Compare
Yup I see, sorry have 5 things going on atm :/ Looks good to me except I don't know if it'll break people that upgraded to 1.6.0 and already dumped a new autoloader.. Maybe we need reverse-BC code? |
3f2fe70
to
cb0f89f
Compare
Here we are. |
cb0f89f
to
ce70e0e
Compare
Thanks.. Let's hope no further adverse effect. |
I beg for a new tag please :) |
Yes yes sorry everything is on fire right now, on it ASAP |
Also why are you the only one affected here? Anything special symfony is doing? I just wonder why travis builds haven't caught fire everywhere. |
I think it's because of a cached ClassLoader that were compiled when symfony/phpunit-bridge compiled its variant of phpunit. There must be some unusual autoloader loading logic there. |
Ok 1.6.1 is out |
This needs an emergency release, as it breaks using legacy class-loader, like the one bundled into phpunit.
ping @Seldaek